Skip to content

Conversation

@leebs0521
Copy link
Collaborator

resolved:

📌 과제 설명

  • 리뷰 등록

👩‍💻 요구 사항과 구현 내용

  • 리뷰는 봉사 활동 한건당 한번만 가능하다.
  • 리뷰는 봉사 활동이 완료된 경우에만 작성 가능하다.

✅ PR 포인트 & 궁금한 점

  • 400 에러 핸들러 기존 제목이 이상해서 제가 임의로 바꿨씁니당

Copy link
Collaborator

@m-a-king m-a-king left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

리뷰 생성 검증 테스트가 단단해 보여요. 재밌으셨을 것 같습니다!

//아래와 같이 필드 확장 가능
problemDetail.setTitle("무슨 에러입니다");
// 아래와 같이 필드 확장 가능
problemDetail.setTitle("잘못된 요청입니다");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요 ㅎㅎ

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다

Copy link
Collaborator

@ayoung-dev ayoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@leebs0521 leebs0521 force-pushed the feature/79-add-review-create branch from 28deafa to b2996f3 Compare December 2, 2024 00:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

@leebs0521 leebs0521 merged commit 1c5f3b8 into main Dec 2, 2024
2 checks passed
@leebs0521 leebs0521 deleted the feature/79-add-review-create branch December 2, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants